aimeos-core icon indicating copy to clipboard operation
aimeos-core copied to clipboard

Update Supplier.php

Open switch-cheehau opened this issue 3 years ago • 6 comments

Refer to #242

switch-cheehau avatar Jul 21 '21 06:07 switch-cheehau

Hi Aimeos,

I tried the method suggested. let me know if any issue.

The concern is it's difficult for user to configure at frontend image

This section seems redundant. should i delete it?

https://github.com/aimeos/aimeos-core/blob/e99c19b7fa5f0ac1776658f09df8b719284e0163/lib/mshoplib/src/MShop/Service/Provider/Decorator/Supplier.php#L112-L131

switch-cheehau avatar Jul 21 '21 06:07 switch-cheehau

Coverage Status

Coverage decreased (-2.3%) to 86.268% when pulling e9e049db51fd341da0d15317783f0461818a9640 on cgcomputers:make-supplier-address-format-configurable into 999f90771cae555eb366b6940a9f470cb2a52e8f on aimeos:master.

coveralls avatar Jul 21 '21 06:07 coveralls

Yes, it's more difficult to configure but supports every format users want to use. Make sure you add the explaination of the placeholders to the label in $beConfig. The block you've mentioned can be removed.

aimeos avatar Jul 21 '21 07:07 aimeos

Yes, it's more difficult to configure but supports every format users want to use. Make sure you add the explaination of the placeholders to the label in $beConfig. The block you've mentioned can be removed.

Okay, will do that, at least in future, hopefully backend able to support textarea input

switch-cheehau avatar Jul 21 '21 07:07 switch-cheehau

You can add new types here: https://github.com/aimeos/ai-admin-jqadm/blob/master/admin/jqadm/templates/service/item-standard.php#L335-L362

aimeos avatar Jul 21 '21 07:07 aimeos

You can add new types here: https://github.com/aimeos/ai-admin-jqadm/blob/master/admin/jqadm/templates/service/item-standard.php#L335-L362

Refer to aimeos/ai-admin-jqadm#199

switch-cheehau avatar Jul 21 '21 10:07 switch-cheehau