FEDOT icon indicating copy to clipboard operation
FEDOT copied to clipboard

Add unit tests for ALL InputData and Data classes methods #1200

Open andreygetmanov opened this issue 1 year ago • 5 comments

Summary

Solution of #1200 issue. Add unit tests for:

  • [x] 1. Classification tasks:
    • [x] 1.1 Binary classification
    • [x] 1.2 Multitarget classification
  • [x] 2. Regression task
  • [ ] 3. Time series forecasting tasks:
    • [ ] 3.1 Unidimensional case
    • [ ] 3.2 Multi_ts case
    • [ ] 3.3 Multidimensional time series case
  • [ ] 4. Multimodal case:
    • [x] 4.1 Classification (bi- and multitarget)
    • [ ] 4.2 Regression
    • [ ] 4.3 Time series forecasting (unidimensional and multi_ts)

Context

Closes #1200

andreygetmanov avatar Jan 19 '24 14:01 andreygetmanov

Hello @andreygetmanov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 6:1: F401 'typing.Callable' imported but unused Line 158:52: F811 redefinition of unused 'data_setup' from line 18

Comment last updated at 2024-02-20 13:01:55 UTC

pep8speaks avatar Jan 19 '24 14:01 pep8speaks

All PEP8 errors has been fixed, thanks :heart:

Comment last updated at

github-actions[bot] avatar Jan 19 '24 14:01 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5e726e9) 80.05% compared to head (936d8f9) 80.06%. Report is 3 commits behind head on master.

:exclamation: Current head 936d8f9 differs from pull request most recent head b5b7a1a. Consider uploading reports for the commit b5b7a1a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   80.05%   80.06%           
=======================================
  Files         149      149           
  Lines       10278    10278           
=======================================
+ Hits         8228     8229    +1     
+ Misses       2050     2049    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 19 '24 15:01 codecov[bot]

/fix-pep8

andreygetmanov avatar Feb 20 '24 13:02 andreygetmanov

не уверен, что прав, но я бы не стал плодить множество функций вида get_*_data_from_*, а написал бы одну функцию считывания данных, где можно менять аргументы. кажется, таким образом не будет 100500 функций, каждая из которых служит обвязкой для InputData.from_*

Поправил

andreygetmanov avatar Feb 20 '24 13:02 andreygetmanov