Redundant information in last commit

[patrickfrei]

Hi ailon,

In lines 235-238: Why don't you just simly write... result.CanonicalManufacturer = manufacturer; ...?

And in line 219: CanonicalManufacturer = manufacturer,

From the switch/case statement in lines 25-26, the variable "manufacturer" is always filled with the respective manufacturer name (either Nokia or Microsoft). This would make the code easier and would also prevent an implementation of redundant Information, such as "CanonicalManufacturer="MICROSOFT" (see lines 522-525).

What do you think?

Best regards, Patrick

[patrickfrei]

Hi ailon,

What do you think about this suggestion?

Best regards, Patrick

[ailon]

Lumia 535 for example returns either NOKIA or Microsoft as manufacturer in about 50/50 proportion. So this won't work.

Alan.

[patrickfrei]

Does this behavior depend on the OS version? I.e. versions after the takeover of Nokia by Microsoft show Microsoft as manufacturer?

[ailon]

I think it's mostly about hardware revision or lot or whatever.

---

From: patrickfreimailto:[email protected] Sent: ‎2015-‎02-‎22 13:40 To: ailon/PhoneNameResolvermailto:[email protected] Cc: Alan Mendelevichmailto:[email protected] Subject: Re: [PhoneNameResolver] Redundant information in last commit (#11)

Does this behavior depend on the OS version? I.e. versions after the takeover of Nokia by Microsoft show Microsoft as manufacturer?

---

Reply to this email directly or view it on GitHub: https://github.com/ailon/PhoneNameResolver/issues/11#issuecomment-75431570

[patrickfrei]

Ok, thank you for your feedback!