gobcog icon indicating copy to clipboard operation
gobcog copied to clipboard

[Command Bug] "Backpack sellall cursed" ignores the string and sells all items

Open tmoze315 opened this issue 4 years ago • 2 comments

Complete these first

  • [ ] I confirm that I am the owner of the bot running Adventure.
  • [x] I confirm that I have not modified the source code of Adventure.
  • [x] I'm an Adventure user but not the bot owner.
  • [x] I confirm that I have checked the issue tracker and a this bug hasn't been reported already.

Command name

[p]backpack sellall cursed

Expected Behavior

It should tell you that you used an invalid string and warn you that it will sell ALL your items. For example, one use thought they could sell all cursed items with backpack sellall cursed. It showed the confirmation "Are you sure you want to sell all your items", which wasn't 100% clear to them that using 'cursed' didn't work.

Current Behavior

It shows a confirmation asking whether the user wants to sell all their items.

Possible Solution

Show a message saying "cursed did not match any rarity or slot". And prevent you from selling anything.

Steps to Reproduce

Use the command [p] backpack sellall cursed

Context (Environment)

The command deleted all of a user's backpack when they thought it was only deleting cursed items.

Detailed Description

Add more protection around this

tmoze315 avatar Sep 21 '20 20:09 tmoze315

Cursed is not a slot or rarity. Check [p]help backpack sellall

Drapersniper avatar Sep 21 '20 20:09 Drapersniper

Since slot and rarity are optional, sellall default behaviour is to sellall.

Drapersniper avatar Sep 21 '20 20:09 Drapersniper