Alex

Results 951 comments of Alex

@Vidzz , feel free to close the issue if it was resolved.

@Tuurlijk can you please rebase and squash commits in this PR? This also seem to resolve #104, but in current state (lots of commits) it's pretty hard to figure out...

I don't understand what the change is for (you haven't provided description in the PR).

Still not getting it, sorry. What does it change in UI or how it's affecting any existing logic?

Then a line above https://github.com/preinheimer/xhprof/blob/master/xhprof_html/callgraph.php#L59 should be updated as well to include SVG. Any way to change format of call graph to SVG from config (see https://github.com/preinheimer/xhprof/blob/master/xhprof_lib/config.sample.php)? What benefits do...

Unfortunately I don’t have any experience with writing PHP extensions. My best guess would be looking at changes in PHP extension at Facebook repository (origin of the fork) to find...

Have you tried the PDO driver: https://github.com/preinheimer/xhprof/blob/master/xhprof_lib/utils/Db/Pdo.php ? If that doesn't work you can create a driver for Postgres and submit it in the PR.

The `graphviz` package itself is listed in README, but `graphviz-devel` and `graphviz-gd` are not. Please send a PR for adding them.

There is also something wrong with commit you've used to create the PR branch, because surely you haven't made 9 commits just to create 1 function. Rebasing and force pushing...

The approach of connecting xhprof via Composer and then setting a constant (or env variable) indicating actual XHProf config doesn't look too intuitive. Also if installed via Composer you won't...