Alex
Alex
> It will be a blocker for Drupal 11 @andypost , please explain how Mink method signatures are affecting/blocking Drupal?
> Please keep any discussion about the changing the Mink API in the main Mink repo rather than in drivers please. Understood. Moved the issue to the main repo.
> (clean) Or revert relevant switchToIFrame method signature changes, because $name can't be declared as both integer and string (in supported PHP versions). Implemented in these PRs: 1. https://github.com/minkphp/Mink/pull/867 (merge...
@uuf6429 , I'm not saying it's a bug. I'm saying that method signature change has prevented certain (might not be documented) Mink usage scenarios from working. Since method DocBlock always...
Update: with the help of the @uuf6429 , I was able to get frame switching by name working on Selenium 3 (see https://github.com/minkphp/MinkSelenium2Driver/pull/382).
@stof , I only need a review from you. The merging and build rerunning I can do myself to save your time. Also please look at the https://github.com/minkphp/MinkSelenium2Driver/pull/382.
Agreed. Here are the actions I've performed based on your response: ### Closed * https://github.com/minkphp/Mink/pull/867 * https://github.com/minkphp/MinkSelenium2Driver/pull/378 * https://github.com/minkphp/webdriver-classic-driver/pull/11 ### Repurposed * https://github.com/minkphp/driver-testsuite/pull/87 (tests frame switching by an ID)
Please specify the steps you've performed for Mink installing and the code you're using to run Mink. Also, have you been able to perform the Composer Install step?
This PR also includes the changes from #842 . Not sure if that was planned.
Please rebase and solve conflicts.