aiida-quantumespresso icon indicating copy to clipboard operation
aiida-quantumespresso copied to clipboard

Published 20 hours ago • verified publisher icon aiidateam

♻️ REFACTOR: Revisit/clean up each parser for legacy code

Open mbercx opened this issue 3 years ago • 0 comments

From v4.0.0, we have a clear policy on which QE versions the plugin will support. This would be a good time to go through each of the parsers and clean up any code that is designed to support old output formats. And, well, after having gone through the ProjwfcParser, clean up the code itself.

Below is a checkbox list with the various codes we have to look at. Once a PR is merged that cleans up the parser, these can be ticked!

  • [ ] CpParser
  • [ ] DosParser
  • [ ] MatDynParser
  • [ ] NebParser
  • [ ] PhParser
  • [ ] PpParser
  • [ ] ProjwfcParser
  • [ ] PwParser
  • [ ] Pw2gwParser
  • [ ] Pw2wannier90Parser
  • [ ] Q2rParser

We should also refactor the XML parsing to make it as generic as possible, avoiding code duplication and cleaning up a lot of the legacy-supporting code.

Also related to https://github.com/aiidateam/aiida-quantumespresso/issues/600

mbercx avatar Oct 03 '21 13:10 mbercx