aiida-core icon indicating copy to clipboard operation
aiida-core copied to clipboard
verified publisher icon aiidateam

`Transport`: deprecate unused function `chown`

Open khsrali opened this issue 8 months ago • 3 comments

While we find out there is not test in place for chown we also realized the function is not used across the interface, and it's not even implemented in our well used and well tested core.ssh plugin.

Therefore, I suggest to deprecate chown functionality at once, instead of maintaining it.

khsrali avatar Apr 23 '25 15:04 khsrali

Hi @khsrali , may I work on this issue?

ayushjariyal avatar Apr 23 '25 16:04 ayushjariyal

Thanks for your interest I'd wait for the team, if they'd with my suggestion.

khsrali avatar Apr 23 '25 16:04 khsrali

True, I could not find any usage for it in the whole code, there is not even a test. The function has been added with commit 4b9bbbf816616f48edf767771bd3a3640ac71339 I could not find any PR related to this commit. The commit message is not justifying the choice of this interface. Since within more than 10 years no usage of this function has been found, I think it makes sense to remove it.

agoscinski avatar May 06 '25 06:05 agoscinski