aiida-core icon indicating copy to clipboard operation
aiida-core copied to clipboard

CLI: Dump only `sealed` by default and add `incremental` option

Open GeigerJ2 opened this issue 1 year ago • 2 comments

Previously, no checks were applied on the state of a process. Now, by default, only sealed processes are being dumped to disk. This can be disabled with the new --dump-unsealed flag. In addition, the option of --incremental dumping is added, in which case an incomplete existing dumping output directory can be gradually filled up with data, e.g., while the process is running in conjunction with the --dump-unsealed flag. Before, only the --overwrite flag was available for this purpose, which would, however, clean the entire top-level directory.

Lastly, the validate_make_dump_path method was refactored out of the ProcessDumper and put as a normal function into utils.py under tools/dumping.

GeigerJ2 avatar Oct 24 '24 10:10 GeigerJ2

Cheers, thanks for the great review, @agoscinski! I have implemented your proposed changes.

GeigerJ2 avatar Oct 25 '24 08:10 GeigerJ2

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (ef60b66) to head (a20538a). Report is 185 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/cmdline/commands/cmd_process.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6591      +/-   ##
==========================================
+ Coverage   77.51%   77.87%   +0.37%     
==========================================
  Files         560      567       +7     
  Lines       41444    42120     +676     
==========================================
+ Hits        32120    32796     +676     
  Misses       9324     9324              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 25 '24 09:10 codecov[bot]