aiida-core icon indicating copy to clipboard operation
aiida-core copied to clipboard

Bump wrapt version to 1.14 fix conda install issue for py310

Open unkcpz opened this issue 1 year ago • 6 comments

wrapt conda forge don't have py3.10 support for the wrapt=1.11. Bump it to 1.14 so can be installed by conda with python 3.10.

unkcpz avatar Oct 12 '22 21:10 unkcpz

There is also an issue with the conda install CI test, it passed but actually, it failed. https://github.com/aiidateam/aiida-core/actions/runs/3231971798/jobs/5305795322

I guess it resolve the version but can not find the correct one and fallback to old version.

unkcpz avatar Oct 12 '22 21:10 unkcpz

Do I need to update the requirements-*.txt manually?

unkcpz avatar Oct 13 '22 10:10 unkcpz

Normally this is done automatically by the test-install/check-requirements job but that failed in the commit action: https://github.com/aiidateam/aiida-core/actions/runs/3237939116/jobs/5305812604 Might be transient problem or maybe that action is broken.

sphuber avatar Oct 13 '22 12:10 sphuber

It seems it need write permission for this peter-evans/commit-comment step in CI workflow. The workflow end up with error "Error: Resource not accessible by integration"

Current runner version: '2.298.2'
Operating System
Runner Image
Runner Image Provisioner
GITHUB_TOKEN Permissions
  Actions: read
  Checks: read
  Contents: read
  Deployments: read
  Discussions: read
  Issues: read
  Metadata: read
  Packages: read
  Pages: read
  PullRequests: read
  RepositoryProjects: read
  SecurityEvents: read
  Statuses: read

unkcpz avatar Oct 13 '22 13:10 unkcpz

As https://github.com/github/codeql-action/issues/464#issuecomment-828811531 suggested. Maybe change setting to:

permissions:
  security-events: write

unkcpz avatar Oct 13 '22 13:10 unkcpz

Okay, I make some tests by playing around the permissions: but it did not take effect here. It take effect from my own forked repository. I find from here that it is limited by the organization. I think it needs to be admin of the aiidateam to change it. I guess it is @giovannipizzi?

unkcpz avatar Oct 13 '22 15:10 unkcpz

By the way @unkcpz why is this update in dependency for wrapt even necessary? The wrapt~=1.11 allows to install wrapt==1.14 and up just fine. What is this change even accomplishing?

sphuber avatar Oct 19 '22 17:10 sphuber

We use mamba to install aiida-core from conda-forge in aiidalab-docker-stack, if the python version pinned to py3.10, it failed with:

Pinned packages:
  - python 3.10.*


Encountered problems while solving:
  - package aiida-core-2.0.4-pyh1a96a4e_0 requires wrapt ~=1.11.1, but none of the providers can be installed

But you are right, ~=1.11 can install ~=1.14, and if using conda instead of mamba it shows a different dependency error.

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versionsThe following specifications were found to be incompatible with your system:

  - feature:/linux-64::__glibc==2.31=0
  - feature:|@/linux-64::__glibc==2.31=0

Your installed version is: 2.31

So it is not the issue of wrapt, I'll close this for now.

unkcpz avatar Oct 20 '22 08:10 unkcpz