aiida-core icon indicating copy to clipboard operation
aiida-core copied to clipboard

Published 20 hours ago • verified publisher icon aiidateam

Refactor the `aiida.manage.tests` fixture manager code

Open sphuber opened this issue 3 years ago • 3 comments

See PR #4360 for the reason why. Because the fixture manager code rolls its own code to create configs and profiles, and the code is not tested, it is too easy for changes in the main code to break the fixtures. The fixture manager should reuse the same code to create profile as verdi setup.

sphuber avatar Sep 09 '20 20:09 sphuber

Tagging @ltalirz

greschd avatar Sep 09 '20 21:09 greschd

certainly agree this would be nice to have :-) the fixture manager needs a bit of cleverness for temporary profiles etc. but I'm sure it could reuse more code

ltalirz avatar Sep 10 '20 07:09 ltalirz

@sphuber maybe worth checking to which degree this still applies.

Code is in https://github.com/aiidateam/aiida-core/blob/d0ff88986391691a0307d0cafb300dbf48e303b3/aiida/manage/tests/main.py#L70

ltalirz avatar Feb 24 '22 13:02 ltalirz