Ignas Anikevicius
Ignas Anikevicius
I wonder if #1653 is related? Shall we close this issue in favour of the newer one?
Right now the `examples/bzlmod` suceeds locally on a linux laptop: ``` bazel build @pip//pylint ``` However `pyyaml` is not available as a `whl` yet, hence the failure of the tests.
This depends on #1750 and #1764. Will continue work on this once those get merged.
This should merge #1811 as the right fix for platform specific wheel platform setting.
I'll close this for now as I focus on the implementation outlined in [this design doc](https://docs.google.com/document/d/1vAupaen4tIZxeqdpkYleuUUjrVuptdps_mz4Y_V4EIo/edit#heading=h.ga06bz2494ba).
What about using `scikit-rf` in one of the examples to test this? I think the part that you should change is in `//python/pip_install/private:generate_build_bazel_file.bzl` or something similar.
Consider using https://rules-python.readthedocs.io/en/latest/api/pip.html#package-annotation instead in your setup to add the extra excludes. There is also a `bzlmod` example for this: https://github.com/bazelbuild/rules_python/blob/main/examples/bzlmod/MODULE.bazel#L84
I am reopening to keep the discussion context from above in one place. Thanks @bruno-digitbio for a nice write up. Macros that live in requirements.bzl are somewhat hard to maintain...
I personally think we have to move carefully to not break existing usecases but at the same time solve the actual problem we are having and I think the friction...
Maybe we could use `bazel-features` ruleset here. Anybody wishing to contribute to `rules_python` could pick this up as this may be a good first issue.