aigis icon indicating copy to clipboard operation
aigis copied to clipboard

include/exclude option for source files with glob pattern

Open ktsn opened this issue 8 years ago • 4 comments

Hello, thank you for your great tool. I feel really comfortable to use it.

I think it would be very nice if we can specify glob pattern for source files in order to handle complex directory structures. Also exclude option would be useful.

Maybe for example:

source_include:
  - src/**/*.scss
source_exclude:
  - src/sub_project/**

How would you feel about this?

ktsn avatar Nov 09 '16 08:11 ktsn

Hello, thank you for good idea!

I think it would be very nice if we can specify glob pattern for source files in order to handle complex directory structures. Also exclude option would be useful.

I agree with you 👍

However that example is included breaking change. I think source and source_exclude are better way:

source:    
    - src/**/*.scss
source_exclude:                    
    - src/sub_project/**

also make source_include an alias for source optionally.

I'll planning implement source_exclude options on next update 👍

nakajmg avatar Nov 14 '16 06:11 nakajmg

Hi, @nakajmg. Thanks for your reply!

My intention for source_include is to avoid breaking change of the source option's behavior. If the source accepts glob pattern, we cannot just specify directory name for it.

Let me summarize my suggestion:

  • source -> no changes, expects directory names
  • source_include -> expects glob patterns, matched files are added as source.
  • source_exclude -> expects glob patterns, matched files are removed from source.

ktsn avatar Nov 14 '16 07:11 ktsn

Thank you for the summary!! I got it 👍 source_include and source_exclude options are so nice.

We will planning to implement source_include and source_exclude options on next update 💁

(also We will planning to use globby instead of node-glob inside Aigis. If you have other good ideas, Please tell us.)

nakajmg avatar Nov 16 '16 10:11 nakajmg

Thanks! I'm looking forward to the next version 🙂 globby looks pretty good 😄

ktsn avatar Nov 16 '16 16:11 ktsn