pytorch-topological icon indicating copy to clipboard operation
pytorch-topological copied to clipboard

Published 20 hours ago • verified publisher icon aidos-lab

Make TOGL feature complete

Open marcusblake opened this issue 1 year ago • 5 comments

Currently, the implementation of TOGL ignores the following features:

  • handling higher-order information properly
  • expanding simplicial complexes
  • making use of the dimension of features

marcusblake avatar Jan 01 '23 07:01 marcusblake

Some of these are rather tough to handle; this should probably rather become a project on its own. In the original paper, for instance, we are not actually going beyond dimension 1 in terms of features, so I am somewhat loath to mix the re-implementation of TOGL with new feature development. A good starting point would be to see how to capture 1-dimensional information; in my current implementation, I figured that I could get this stuff much more easily by using a lower star filtration.

Pseudomanifold avatar Jan 01 '23 16:01 Pseudomanifold

Hi @Pseudomanifold, is this a good place to pick up on where we left off in BorgwardtLab/TOGL#13, or should I open a new ticket?

uchukwu avatar Mar 05 '24 00:03 uchukwu

Sure!

Pseudomanifold avatar Mar 05 '24 08:03 Pseudomanifold

Thanks! You mentioned that TOGL isn't complete yet during our discussion. What is missing? What features do you need added?

uchukwu avatar Mar 08 '24 00:03 uchukwu

Potentially some other aggregation functions would be useful; I also have not tried out how easy it is to include this type of layer into arbitrary GNNs. Except for the aggregation functions, I think this is relatively in sync with the other code, though.

Pseudomanifold avatar Mar 08 '24 15:03 Pseudomanifold