million icon indicating copy to clipboard operation
million copied to clipboard

Million.js Lint Not Working

Open Bader975 opened this issue 11 months ago • 25 comments

What version of million are you using?

V3.0.6

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

npm

What operating system are you using?

windows

What browser are you using?

Chrome

Describe the Bug

Million.js Lint not working Screenshot 2024-03-17 072717

What's the expected result?

it's should give hits to speed up my React app

Link to Minimal Reproducible Example

none , no error

Participation

  • [ ] I am willing to submit a pull request for this issue.

Bader975 avatar Mar 17 '24 04:03 Bader975

Thanks for opening this issue! A maintainer will review it soon.

github-actions[bot] avatar Mar 17 '24 04:03 github-actions[bot]

Same problem.

My nextjs config file: (tryed with and without rsc, both auto mode) image

yarn run dev cli messages image

lucarampi avatar Mar 18 '24 13:03 lucarampi

Same problem here: image

Info:

  • Windows 11
  • yarn: 4.1.1
  • vite: 5.1.6
  • @million/lint: 0.0.73

AndreiTS avatar Mar 18 '24 17:03 AndreiTS

Same problem here:

  • Mac 14.3.1
  • NextJS 13.5
  • Yarn 3.3.0
  • @million/lint: 0.0.73

Alcas1 avatar Mar 18 '24 17:03 Alcas1

Same! 👋

  • Mac Sonoma 14.2
  • Vite v5.0.12
  • Yarn 4.0.2
  • @million/lint: 0.0.73

oskarscholander avatar Mar 18 '24 18:03 oskarscholander

I get this issue as well when running in a bun workspace, however when I run on a different app using npm and not in a workspace, the linting works fine.

BaileyNepe avatar Mar 18 '24 20:03 BaileyNepe

same

Windows 11 npm: 10.5.0 vite: 5.1.6 @million/lint: 0.0.73

cold-world avatar Mar 19 '24 15:03 cold-world

same

Windows 11 npm 10.2.5 next 14.1.3 @million/lint 0.0.73

N0SAFE avatar Mar 19 '24 19:03 N0SAFE

Same here!

Windows 11 npm 10.2.4 vite 5.0.10 @million/lint: 0.0.73

EliKnoph avatar Mar 20 '24 10:03 EliKnoph

and also it makes errors with react key prop all over the app

cold-world avatar Mar 21 '24 10:03 cold-world

Same

Windows 11 pnpm 8.15.5 vite 5.1.4 @million/lint: 0.0.73

emedeirox avatar Mar 21 '24 20:03 emedeirox

Hmm, thank you all for coming here to report this. I have reported this team and it's currently being worked on. Appreciate it:

  • @Bader975
  • @lucarampi
  • @AndreiTS
  • @Alcas1
  • @oskarscholander
  • @BaileyNepe
  • @cold-world
  • @N0SAFE
  • @EliKnoph
  • @emedeirox

tobySolutions avatar Mar 21 '24 20:03 tobySolutions

Hi, mine is the same, but I have a vscode notification that says: "million lint is successfully installed...waiting for connection" and never disappears. I tried logging into: https://lint.million.dev, but it immediately says: "session expired, log in again".

To test the linter, I've used a client component with a useEffect that runs setState(v => v + 1) indefinitely, producing infinite re-renders. Is it a good test that million lint should be able to recognize?

giovanniincammicia avatar Mar 23 '24 16:03 giovanniincammicia

Hi, mine is the same, but I have a vscode notification that says: "million lint is successfully installed...waiting for connection" and never disappears. I tried logging into: https://lint.million.dev, but it immediately says: "session expired, log in again".

To test the linter, I've used a client component with a useEffect that runs setState(v => v + 1) indefinitely, producing infinite re-renders. Is it a good test that million lint should be able to recognize?

We're currently working on this actually. A fix will be sent in the next patch of the Million lint release

tobySolutions avatar Mar 23 '24 16:03 tobySolutions

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

github-actions[bot] avatar Apr 08 '24 00:04 github-actions[bot]

Has there been any progress on this? Particularly with it not working in a workspace?

brendon1555 avatar Apr 10 '24 03:04 brendon1555

The same issue for me (react/vite, yarn, mac os) fixed with:

  1. yarn add -D million@latest
  2. yarn add -D @million/lint
  3. vite.config.ts: ... import million from 'million/compiler'; import MillionLint from '@million/lint';

export default defineConfig({ plugins: [ ... react(), million.vite({ auto: true }), MillionLint.vite(), ], ... });

sudexp avatar Apr 10 '24 13:04 sudexp

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

github-actions[bot] avatar Apr 27 '24 00:04 github-actions[bot]

Not stale

Alcas1 avatar Apr 27 '24 01:04 Alcas1

Same as all the others.

Windows 10 pnpm 8.8.8 next 14.2.3 @million/lint 0.0.73

J4v4Scr1pt avatar Apr 29 '24 08:04 J4v4Scr1pt

The same issue for me (react/vite, yarn, mac os) fixed with:

  1. yarn add -D million@latest
  2. yarn add -D @million/lint
  3. vite.config.ts: ... import million from 'million/compiler'; import MillionLint from '@million/lint';

export default defineConfig({ plugins: [ ... react(), million.vite({ auto: true }), MillionLint.vite(), ], ... });

this works with million lint but it gives a lot of errors in project like missing key props in react, react-hook-form and tanstack-query not working properly.

cold-world avatar Apr 29 '24 08:04 cold-world

@cold-world how install Million.js lint on Next,js 14 ?

Bader975 avatar Apr 30 '24 10:04 Bader975

@cold-world how install Million.js lint on Next,js 14 ?

Hey there, just follow this: https://million.dev/docs/introduction

tobySolutions avatar May 03 '24 07:05 tobySolutions

Hitting the same issue, any updates?

jacksmethurst avatar May 15 '24 17:05 jacksmethurst

Is there any new updates?

oskarscholander avatar May 16 '24 08:05 oskarscholander

Please continue the thread here: #1029

aidenybai avatar May 23 '24 06:05 aidenybai