million icon indicating copy to clipboard operation
million copied to clipboard

Fix: Responding to style and processed props

Open nojiritakeshi opened this issue 1 year ago • 4 comments

Please describe the changes this PR makes and why it should be merged: The following issues were resolved.

  1. when style is set to a property that contains uppercase letters.
  2. When you want to render processed arguments.

More on this Issue. https://github.com/aidenybai/million/issues/465

Status

  • [x] Code changes have been tested against prettier, or there are no code changes
  • [x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • [x] This PR changes the codebase
    • [ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • [x] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • [ ] This PR only includes non-code changes, like changes to documentation, README, etc.

nojiritakeshi avatar Jul 06 '23 14:07 nojiritakeshi

image

Hey @nojiritakeshi, thank you for this. Can you please run pnpm lint locally to resolve these issues?

tobySolutions avatar Jul 07 '23 07:07 tobySolutions

@tobySolutions Thank you. But, I will also check for compatibility with the commit https://github.com/aidenybai/million/commit/0820c9a09361bf58ba1aa5905d4e0ea837042a45.

nojiritakeshi avatar Jul 07 '23 10:07 nojiritakeshi

@tobySolutions I ran pnpm lint locally and didn't get the same error, do you know why?

Apart from that, the comment was in the wrong place, so I fixed it.

nojiritakeshi avatar Jul 09 '23 08:07 nojiritakeshi

sorry...I noticed that this modification was unnecessary once the compiler was set up correctly. This fix is to make it work even if the compiler is not used. If it's an unnecessary correction, we'll remove this PR immediately.

nojiritakeshi avatar Jul 09 '23 12:07 nojiritakeshi

I don't think this is the correct approach, we want the holes to be objects to be safe. I will push a PR soon that tries to approach this issue. would love your feedback on it :)

aidenybai avatar Jul 16 '23 20:07 aidenybai

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nojiritakeshi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 20 '23 23:07 CLAassistant