Aidan Woods
Aidan Woods
It's been a while, but now very close to a finished product for 2.0 in Parsedown (https://github.com/erusev/parsedown/pull/708) and ParsedownExtra (https://github.com/erusev/parsedown-extra/pull/172). I'd appreciate any feedback you have :)
In 2.0 (not yet release) this could be done with (or something very similar to) the following: ```php $State = new State; $InlineTypes = $State->get(InlineTypes::class)->removing([Url::class, Link::class, Image::class]); $State = $State->setting($InlineTypes);...
See also: https://github.com/erusev/parsedown/issues/534 This is definitely something that I want to address. I think I'd be looking at more of an interface based approach to "extensions" going forward as opposed...
Once it's finished, this should be solved by: #685
It's not released yet, but I've explained a little how I think this will work going forward over in: https://github.com/erusev/parsedown/pull/708#issuecomment-944799267. Feedback welcome!
This falls more under intended behaviour ([CommonMark result](https://spec.commonmark.org/dingus/?text=%3Cdetails%3E%0A%3Csummary%3ECLICK%20ME%3C%2Fsummary%3E%0A...%20formatting%20like%20_italics_%2C%20**bold**%2C%20etc.%20all%20fail%2C%20just%20because%20there%27s%20a%20missing%20line.%20%3E%20Blockquote%20without%20a%20precending%20blank%20line%20is%20assumed%20to%20belong%20to%20the%20previous%20line%20%60%60%60%20and%20the%20same%20with%20code%20blocks.%20%60%60%60%0A%3C%2Fdetails%3E)), and it's due to how [HTML blocks are defined](https://spec.commonmark.org/0.28/#html-blocks). This is also consistent with GitHub's result. In other words it is intentional...
I was actually just in the process of exploring a fix around moving more towards the CommonMark spec for defining the opening and closing delimiter runs: since this'll help avoid...
Bug according to the [GitHub flavoured markdown spec][1]: regarding trailing punctuation, parentheses are permitted as part of the link if they balance (which they do in this case) (@erusev which...
I dropped out the bugfix commit and have merged it ahead of this PR via #584 since I found a related issue open.
Copy pasting the pros and cons list specific to this implementation from https://github.com/erusev/parsedown/pull/538#issuecomment-376339414 since it probably merits inclusion in the actual PR: --- A couple things to note about ```markdown...