Aidan Do
Aidan Do
Thank you @eddumelendez for the review. I've addressed your suggestions.
My pleasure @kiview
@null-sys Thanks, we would love to get your help! No need to assign yourself haha (I don't have permissions to assign). Just submit a PR and you should be good...
Thank you @kiview for the review - I've addressed your comments. I'm feeling more comfortable with this PR now as it gets rid of dead code and increases meaningful test...
I've updated this with master - hopefully that fixes the build
Thank you @eddumelendez for the review. I've addressed your suggestions. Merged in master as well.
It sees like the latest docs do not suggest usage of `getTestHostIpAddress()` and instead suggest usage of the host exposing mechanism: https://www.testcontainers.org/modules/webdriver_containers/  I think this issue...
``` var info = new Properties(); info.put("allowMultiQueries", "true"); driver.connect("jdbc:tc:mysql:5.7:///?TC_TMPFS=/var/lib/mysql:rw", info); ``` I've been able to reproduce this on my end. It looks like `ContainerDatabaseDriver#connect` ignores the `info` argument completely. Thanks...
JDBC - MSSQL - getLivenessCheckPortNumbers() shouldn't that be the mapped port and not the internal?
Thank you all for your contributions. This issue should be closed now. It's in the 1.17.4 release
Hi @DKarim and reviewers. Hope I am not intruding - I thought I would help address some of the comments on this PR as it seems like @DKarim is busy....