Sasha Aickin

Results 40 comments of Sasha Aickin

@doug-wade thanks for the thoughtful post, and sorry for my delay in jumping in. Life intervenes sometimes. First a small point: > Also, since we Babelify the code for clients,...

> react-server-config > react-server-compiler > react-server-runner At high level, this seems like a good breakdown to me, although I'm not 100% sure how it will work without seeing and thinking...

To make this discussion more concrete, as an experiment I converted the (very simple) HelloWorld test spec to Selenium/Sauce; you can see it [here](https://github.com/aickin/react-server/commit/0cb88bc437bf29201f9af98f882cd3b5be02f923). A few thoughts: - **The tests...

> I'd be interested to get an idea of how much slower they are. I know they're slower than running in zombie, but our tests aren't doing that much. Was...

Actually, I just found [webdriver-manager](https://www.npmjs.com/package/webdriver-manager), which claims to be an npm installable package that handles all you need to get a local Selenium Server going. It's forked out of protractor,...

@doug-wade Thanks for the response! I want to make sure I understand what you're saying, though. Do you mean: 1. that there should be a disjoint set of tests A...

Thanks, @doug-wade, that clarifies things for me, and I think we're basically on the same page. One question for you: how do you feel about testing with a _non-headless_ Firefox?...

Indeed. It was (afaict) totally working, but then it started to be a little flaky, so I didn't think it should merge yet. Then since last Wednesday, I've been sidetracked...

I'd like to bump this feature request, because I'm curious how folks feel about it as a future direction. Would you accept a PR with it? Do you think it's...

Update: I realized last night that this XSS issue might also apply to `router.replace`, and I created a simple repro case to verify that it does. In 18feb4a, I updated...