styled-bootstrap-components icon indicating copy to clipboard operation
styled-bootstrap-components copied to clipboard

adds padding to container and negative margin to rows to align with BS 4 grid

Open apisandipas opened this issue 5 years ago β€’ 6 comments

The Bootstrap grid has a quirky feature of having negative margins on rows. This is because theres ideally 1 container and any number of infinitely nested Rows and Columns. The negative margin on Rows enables this nesting capability and is missing from your implementation, which I quite otherwise like. Hope you will consider this PR and happy coding.

apisandipas avatar Feb 09 '20 05:02 apisandipas

@apisandipas thanks for contributing

I will take a look at this PR as soon as possible.

aichbauer avatar Feb 09 '20 06:02 aichbauer

@apisandipas, hey, I think you should update snapshots and follow this project's code style (Airbnb) to better fit your changes into the repo :+1:

michaelkryukov avatar Feb 09 '20 11:02 michaelkryukov

@apisandipas If you consider the changes @michaelkrukov proposed we could definitely consider this feature/fix.

aichbauer avatar Feb 14 '20 20:02 aichbauer

Updated to removed my 'prettier' formatting, sorry about that. Now you can see, it's a really simple change.

apisandipas avatar Feb 15 '20 02:02 apisandipas

Okay, I've updated the snapshots as requested now too.

apisandipas avatar Feb 16 '20 01:02 apisandipas

Codecov Report

Merging #70 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #70   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         112    112           
  Lines        1808   1808           
  Branches      343    343           
=====================================
  Hits         1808   1808

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update fa159ac...80496f2. Read the comment docs.

codecov-io avatar Feb 16 '20 01:02 codecov-io