styled-bootstrap-components
styled-bootstrap-components copied to clipboard
adds padding to container and negative margin to rows to align with BS 4 grid
The Bootstrap grid has a quirky feature of having negative margins on rows. This is because theres ideally 1 container and any number of infinitely nested Rows and Columns. The negative margin on Rows enables this nesting capability and is missing from your implementation, which I quite otherwise like. Hope you will consider this PR and happy coding.
@apisandipas thanks for contributing
I will take a look at this PR as soon as possible.
@apisandipas, hey, I think you should update snapshots and follow this project's code style (Airbnb) to better fit your changes into the repo :+1:
@apisandipas If you consider the changes @michaelkrukov proposed we could definitely consider this feature/fix.
Updated to removed my 'prettier' formatting, sorry about that. Now you can see, it's a really simple change.
Okay, I've updated the snapshots as requested now too.
Codecov Report
Merging #70 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #70 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 112 112
Lines 1808 1808
Branches 343 343
=====================================
Hits 1808 1808
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update fa159ac...80496f2. Read the comment docs.