downward
downward copied to clipboard
aibasel
Translate: improve error message when files do not start with "(define "
@maltehelmert This is the PR going along this issue http://issues.fast-downward.org/issue1029
I loved to meet you at ICAPS 2022! I hope you don't mind I bump this PR.
Hi @victorpaleologue, I'd normally suggest to use the tracker for pinging but this works as well. We would prefer to improve error reporting in a more general way, rather than fixing assertion messages that are not meant for error reporting. We have this on our list to look into at our next sprint in January and if we can make some progress there, this should also cover reporting a missing "(define". If we don't manage to merge something larger by February, we can merge this diff as a stopgap so it doesn't stay open forever.
The notification email from the tracker bounced. Can you check that your email address there is up to date?
Right, thanks, I’ve just updated my e-mail address there.
I admit I would find it easier to merge it now and start your sprint on top of that (and clean that away if it becomes pointless), rather than trying to rebase it on refactored code.
But I am not in your seat, and I should comply to the maintainers' plans.
Le 5 déc. 2022 à 11:48, Florian Pommerening @.***> a écrit :
The notification email from the tracker bounced. Can you check that your email address there is up to date?
— Reply to this email directly, view it on GitHub https://github.com/aibasel/downward/pull/59#issuecomment-1337124270, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACD4ZXD4ORCZYZDCKQRX6ILWLXB6PANCNFSM5ATBPVEA. You are receiving this because you were mentioned.
[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/aibasel/downward/pull/59#issuecomment-1337124270", "url": "https://github.com/aibasel/downward/pull/59#issuecomment-1337124270", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]
Superseded by #155, so I'm closing this. But thank you for bringing this to our attention! This was what ultimately triggered the more extensive rewrite of the PDDL parser.
