size-limit icon indicating copy to clipboard operation
size-limit copied to clipboard

Using `--why --save-bundle <DIR>` with multiple sections is buggy

Open iMoses opened this issue 10 months ago • 1 comments

I tried using size-limit --why --clean-dir --save-bundle ./test with a config file that looks like this:

const defaultConfig = {
    path: './src/main-modules.ts',
    brotli: false,
};

module.exports = [
    {
        name: 'Full package',
        import: '*',
        limit: '200 kB',
        ...defaultConfig,
    },
    {
        name: 'Testing EventEmitter',
        import: '{ EventEmitter }',
        limit: '20 kB',
        ...defaultConfig,
    },
    {
        name: 'Testing Pool',
        import: '{ Pool }',
        limit: '20 kB',
        ...defaultConfig,
    },
];

While multiple .html report files are generated with different names, as the sections, the .js files generated are always with the same name. This results in only the last section actually being tested (I assume they override each other) and all the reports are taintent and identical. (based on the last section) I didn't look into the library's code yet but I assume the solution should be to also generate multiple index.js files based on the section name.

P.S. It'd also be nice to be able to cancel minification from the config options. This helps a lot when trying to debug why tree-shaking is failing.

iMoses avatar Jan 06 '25 12:01 iMoses

Yes, it is known limit.

We can add warning to output. PR is welcome.

Also, if you have idea how to fix it, I am open for suggestions too.

ai avatar Jan 06 '25 21:01 ai