autoprefixer-rails icon indicating copy to clipboard operation
autoprefixer-rails copied to clipboard

Switch to GitHub Actions

Open olleolleolle opened this issue 3 years ago • 9 comments

This PR adds a GitHub Actions configuration YAML.

Details

Drops Travis CI configuration file and badge.

I borrowed this one: https://boringrails.com/articles/building-a-rails-ci-pipeline-with-github-actions/

TODO

Add builds which do this:

  • [x] "EXECJS_RUNTIME=Node" for Ruby 2.7
  • [x] "EXECJS_RUNTIME=MiniRacer" for all combinations

When I was done, I found: https://docs.github.com/en/actions/learn-github-actions/migrating-from-travis-ci-to-github-actions

olleolleolle avatar Jun 15 '21 11:06 olleolleolle

@albb0920 I am guessing that you, the project maintainer, needs to enable something for this to be replace the other CI. I will drop Travis details in this PR, too.

olleolleolle avatar Jun 15 '21 11:06 olleolleolle

Do you have a repo demonstrate this working? I've checked yours, it seems to have some issues. https://github.com/olleolleolle/autoprefixer-rails/actions/workflows/ci.yml

albb0920 avatar Jun 15 '21 11:06 albb0920

@albb0920 Thanks for the hint, I'll return when I've learned more!

olleolleolle avatar Jun 15 '21 11:06 olleolleolle

@albb0920 OK, seems like it's going better now.

Update: All 🟢 green now.

bild

olleolleolle avatar Jun 15 '21 11:06 olleolleolle

Hi @albb0920, how is it going? travis-ci.org is already ceased, so we'd like to migrate to GitHub Actions.

I ran the CI in my forked repo, and it is mostly green. https://github.com/mishina2228/autoprefixer-rails/actions/runs/1703649823 Tests(macos-latest, 2.6) is failing now, but this is caused by the following issue in mini_racer: https://github.com/rubyjs/mini_racer/issues/223 I'm hoping this issue will be resolved in the near future, so would you consider merging this PR? Thank you!

mishina2228 avatar Jan 16 '22 12:01 mishina2228

Sorry for the delay, I’ll have a look in a few days

2022年1月16日(日) 20:43 mishina2228 @.***>:

Hi @albb0920 https://github.com/albb0920, how is it going? travis-ci.org is already ceased, so we'd like to migrate to GitHub Actions.

I ran the CI in my forked repo, and it is mostly green. https://github.com/mishina2228/autoprefixer-rails/actions/runs/1703649823 Tests(macos-latest, 2.6) is failing now, but this is caused by the following issue in mini_racer: rubyjs/mini_racer#223 https://github.com/rubyjs/mini_racer/issues/223 I'm hoping this issue will be resolved in the near future, so would you consider merging this PR? Thank you!

— Reply to this email directly, view it on GitHub https://github.com/ai/autoprefixer-rails/pull/210#issuecomment-1013869104, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACDO5D2TJU56H77MZCFOBLUWK4NTANCNFSM46XA5TAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

albb0920 avatar Jan 16 '22 12:01 albb0920

Thanks! And now that the mini_racer issue has been fixed, all CIs are green!

mishina2228 avatar Jan 17 '22 13:01 mishina2228

@mishina2228 Anything else you need from me, here? Glad they're green.

olleolleolle avatar Jan 17 '22 13:01 olleolleolle

@olleolleolle Nothing special, but maybe add CI against Ruby 3.1?😆

mishina2228 avatar Jan 17 '22 13:01 mishina2228

Sorry for the very long delay. Rebased & merged, thank you!

albb0920 avatar Sep 09 '22 04:09 albb0920