ChatALL icon indicating copy to clipboard operation
ChatALL copied to clipboard

added a Basic search option

Open syedddanishalinaqvi opened this issue 1 year ago • 8 comments

I think until that Ctrl+F option comes we can use this for searching. Just started with Vue abecause of this project. New to contribution. Open to take feedbacks. Thanks

syedddanishalinaqvi avatar May 19 '23 12:05 syedddanishalinaqvi

i just wrote a code on app.vue. I think because of my formatter so many formats changed

syedddanishalinaqvi avatar May 19 '23 12:05 syedddanishalinaqvi

great! just a small remark about the indentation of the props, look carefully at the guide style and the indentation of the spaces. It brings a lot of visibility with time that's why I insist. I let the owner @sunner decide what to do next and the level of severity

k4lu-0p avatar May 19 '23 16:05 k4lu-0p

thanks ill keep that thing in my mind.

syedddanishalinaqvi avatar May 19 '23 17:05 syedddanishalinaqvi

Thank you @syedddanishalinaqvi . And thank you @k4lu-0p , you are really a Vue guru.

I also started with Vue for this project. I need some time to understand this PR and what @k4lu-0p insisted (mostly agree), :-)

sunner avatar May 19 '23 22:05 sunner

@syedddanishalinaqvi There are conflicts now. Could you resolve them first?

sunner avatar May 19 '23 22:05 sunner

Done ;)

syedddanishalinaqvi avatar May 20 '23 09:05 syedddanishalinaqvi

@syedddanishalinaqvi This is a great prototype. Nice try 👍

I appreciate your effort, but in my opinion, it can be improved to be usable.

Fortunately, there is an easier solution. I asked ChatGPTs and Bing Chats "How to add 'find in page' in electron app" and found some useful node.js packages such as electron-find and electron-in-page-search. Could you give them a try?

sunner avatar May 20 '23 14:05 sunner

Definitely ill try to work on that.

syedddanishalinaqvi avatar May 20 '23 14:05 syedddanishalinaqvi