Naymul Islam

> Hi, yes! Thats exactly how I meant it. Now you could remove the "error_when_undefined" boolean, because you can either raise an Error if the fallback_value is undefined or use...

> > > Hi, yes! Thats exactly how I meant it. Now you could remove the "error_when_undefined" boolean, because you can either raise an Error if the fallback_value is undefined...

> > Hi could you please have a look at the recent commit and let me know if is there any issue... > > All existing tests are failing, and...

@EwoutH, any ideas on how can fix the build issue?

> Yes, it seems that currently one of the tests [fail](https://github.com/projectmesa/mesa/actions/runs/8207353176/job/22448467124?pr=2067#step:8:37). It’s `test_agentset_get_attribute`, which indicates something is changed in the AgentSet.get() method that breaks that test. The test code is...

> Thanks for this PR! It looks like it could fill a nice use case, especially for attributes with discrete values. > > On thing I'm thinking about is if...

> I also had a quick look. I like the direction. Some quick points: > > 1. how to handle non-discrete attributes? The current code is not explicit on this....

> Thanks for this! Just one thought on the binning conversation and a question regarding the appropriate return type. The code itself, and the tests look fine. Hi sorry for...

> @ai-naymul is this PR ready for (final) review? If so, can you mark it as such (by pressing the "Ready to review") button? > > Please also update the...

@EwoutH Here's a brief overview of the proposed change: Add handle_undefined parameter with default "raise_exception". Introduce fallback_value parameter to specify the value to return when handle_undefined is set to "fallback_value"....