Andreas Haller

Results 51 comments of Andreas Haller

This should be fixed on main via https://github.com/ahx/openapi_first/pull/294. I am keeping this open until the fix has been released. Can you give this a try @moberegger ? Thanks again for...

> The other difference is that we're using file references (ex: $ref: ./Dog.yml) which may be impacting how it gets loaded Yes. And this should not work without using `mapping`,...

Hi @moberegger thanks for message. No worries. If you get to looking at this again, can you try if the code on _main_ works for you? Thanks.

I reproduced this issue within https://github.com/ahx/openapi_first/blob/v2.2.0/spec/middlewares/response_validation_spec.rb#L301-L340 and just released a fix in version 2.2.0. I think that should solve it. Thanks for the report, Michael!

This change is super useful, even in it's current state. I am building a ruby library against this right now ♥️

Hi. ~Can you try https://github.com/ahx/openapi_first/pull/282 to see if that fixes the problem?~ I just released 2.0.4, which should fix this. Thanks for the report.

Hi. Thanks for taking a look at this again. I think I should try to reproduce this in a real Rails app. I have started to [put something together](https://github.com/ahx/openapi_first/tree/main/examples/rails_app) based...

Well, two weeks have passed and I did not get to work on this. Sorry. If you have time to compile an example app with a failing rspec request test,...

Alright. I think I got it fixed in 2.1.1 via https://github.com/ahx/openapi_first/pull/289.

The [OAS says ](https://spec.openapis.org/oas/v3.1.0#discriminator-object): "When using the discriminator, inline schemas will not be considered." This means that the example (without the `$refs`), should not work. I [have also asked in...