Andrew Huth
Andrew Huth
It does seem like a good idea, though. Do you want to take a shot at doing this and making a pull request? For an example of how to tie...
Sorry it took me so long to get back to this, and thanks for the kind words. There's 2 issues with fixing this, though: First, this plugin is very simple...
Yes, I can absolutely pair up on this. I'll reach out.
I'm seeing this now, but only when upgrading from Storybook 8.6.7 to 8.6.12 🤔. Will look into this tomorrow. Thanks for reporting.
~~Don't see this issue with Webpack + React 19.1.0 + Storybook 8.6.12. Wonder if it's specific to Vite.~~ nvm. I can repro this on another app using Webpack. But can't...
https://github.com/chanzuckerberg/axe-storybook-testing/pull/109 resolves this for me. @surgeboris can you try applying the same changes, and see if it resolves it for your case, too?
Super weird. It used to be the case that [storyRendered](https://github.com/ahuth/axe-storybook-testing/blob/384d0149666f2e533eecc95dfee415016a480169/src/browser/StorybookPage.ts#L158) happens after play functions ran, but maybe that's changed, or there's a race condition, or something.
A workaround for the time being could be to un-deprecate `waitForSelector` and use it to wait for the result of a play function (if possible).