python-magic icon indicating copy to clipboard operation
python-magic copied to clipboard

Published 20 hours ago • verified publisher icon ahupp

GitHub Actions: Add testing on Windows

Open cclauss opened this issue 1 year ago • 2 comments

Currently testing on Windows is commented out in our GitHub Actions. https://github.com/ahupp/python-magic/blob/aa49677fbec9a4fc96b54e42c2517a2118d66db8/.github/workflows/ci.yml#L13-L14

Linux and macOS work just fine but on Windows the tests never complete.

cclauss avatar May 16 '24 16:05 cclauss

here are the pytest failues on windows: https://github.com/ahupp/python-magic/pull/294#discussion_r1590782796

when they're fixed (or skipped), we could re-introduce pytest in wheels.yml (https://github.com/ahupp/python-magic/commit/84667ee7d3d6bbc6bcf2400105ed322de22417fa) to get proper platform tests:

  • ci.yml would run pytest for different python versions (linux only)
  • wheels.yml would run pytest for different (emulated) cpu architectures and operating systems (including the different mac and windows flavours)

ddelange avatar May 23 '24 14:05 ddelange

I prefer a test job that runs the tests. And a separate wheels / deployment job that is focused on moving to production. However I don’t want to do anything that slows down this PR.

cclauss avatar May 23 '24 18:05 cclauss