lmdb-safe

lmdb-safe copied to clipboard

Comparison with lmdbxx?

6

Hi, neat looking project! I was wondering if you could weigh in a bit on how this compares to the lmdbxx library by Arto Bendiken (@artob): https://github.com/drycpp/lmdbxx The automatic conversion...

hoytech

avoid std::move() on temporary at -werror

10

/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/driver/posix/lmdb-safe/lmdb-safe.cc:336:10: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move] return std::move(getRWTransaction()); ^ /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/driver/posix/lmdb-safe/lmdb-safe.cc:336:10: note: remove std::move call here return std::move(getRWTransaction()); ^~~~~~~~~~ ~ 1 error generated.

mattbenjamin