sioyek icon indicating copy to clipboard operation
sioyek copied to clipboard

rendering issues with file with different bg colors

Open nikinbaidar opened this issue 1 year ago • 3 comments

I tried to open a beamer presentation with a black canvas. If you set the background_color of sioyek to black as well, this annoying little border is shown on the right side, and also at the bottom. The bottom one is probably my page separator, but even if I set the page_separator_width to 0, the border on the bottom still exits at the end of the last page of the file.

sioyek_right_border_issues Example pdf

EDIT: I checked this with zathura, and it works fine there.

nikinbaidar avatar Aug 22 '24 03:08 nikinbaidar

This happens when document size is not an exact integer and mupdf rounds up. Added a "background_pixel_fix" config option in https://github.com/ahrm/sioyek/commit/40151569b95cac47d708447b181e645178082aa0 which works around this issue by simply not rendering the last pixel row and column.

ahrm avatar Aug 22 '24 11:08 ahrm

This addresses my concern. Thank you very much!

nikinbaidar avatar Aug 22 '24 15:08 nikinbaidar

Setting background_pixel_fix = 1 messes up freehand drawings. The drawings aren't displayed at all.

nikinbaidar avatar Sep 16 '24 18:09 nikinbaidar