ahrm
dev branch mac
Hi dear author, thanks for your work. I got a minor problem recently. I'm usign mac and the dev branch fo sioyek. when in full screen and i open a pdf from outside sioyek, it wont get me to sioyek but when not in full screen, opening a pdf from outside sioyek does take me to the app. I'm not sure if i have explained this clearly? i dont think i got this issue before? but anyway thanks for this work
I don't have access to a mac right now, so I will have to debug this issue when I can find one.
Sure thanks!
On 12 Aug 2024, at 3:28 pm, ahrm @.***> wrote:
I don't have access to a mac right now, so I will have to debug this issue when I can find one.
— Reply to this email directly, view it on GitHubhttps://github.com/ahrm/sioyek/issues/1144#issuecomment-2283275682, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BDZGEOLBN5PVU7MVHKE3IR3ZRBPYFAVCNFSM6AAAAABMLSE6XCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBTGI3TKNRYGI. You are receiving this because you authored the thread.Message ID: @.***>
I am not sure which part ensures the windowed mode of sioyek to be focused. Is the focus function of sioyek normal on other platforms?
This is the part that should handle the focus: https://github.com/ahrm/sioyek/blob/dac86a4da927d2ee8f18c4b9523d383b6d487a14/pdf_viewer/main.cpp#L852 .
I plan to first find where the window is focused and then check why this part is not compatible with macOS's fullscreen mode. However, I commented out the line you mentioned, and the file still focuses on the window when opened on macOS. Moreover, this part seems to be code designed for Android?
It also seems that calling ./sioyek /some/path/to/file.pdf from the terminal and opening the file directly in the browser invokes different code? I'm not quite sure.
should be fixed in https://github.com/ahrm/sioyek/pull/1183 Perhaps it is not an elegant method, I did not find the original window focus code