[Bug] _embed_annotations

[Elaws]

Bug description

When using _embed_annotations command, Sioyek embeds more than what was previously highlighted, or embeds improperly.

Steps to reproduce

Bug example 1 :

1. In tutorial.pdf, highlight the word "Use" line 3 (in "Use the arrow keys for navigation").
2. Use the _embed_annotations command.

Result :

Bug example 2 :

1. In tutorial.pdf, highlight the "to fit the document" line 9 (in "Press F9 to fit the document to screen").
2. Use the _embed_annotations command.

Result :

Expected results

In example 1, only the word "Use" line 3 should be highlighted. In example 2, "to fit the document" line 9 should be embedded (it is not embedded, but "to fit the document" line 8 is embedded).

Environment

Windows 11 Sioyek - Commit https://github.com/ahrm/sioyek/commit/caf5569ae896d1d945ec891dddbd48732a5be475

[ahrm]

Should be fixed in the latest version.

[Elaws]

Thanks a lot !

[gokberkgunes]

I am having a similar issue to this one. Using the python command described in the README.md generates embedded highlights above the sioyek highlights.

Here's a picture of python command, _embed_annotations.

Here is the one using the embed_annotations command which is probably built-in to sioyek, I am not sure.

Here one may obtain the open-access pdf file for testing purposes.

[ahrm]

The problem was that the page's mediabox origin was not (0, 0) for some reason. The issue should be fixed in ea161c485f4b7f8d4662ddbc333c5d5f33034ab8.

[naquad]

Same here. Multiple highlights added, wrong places, deleting highlights is impossible.