andrew jarrett

Results 34 comments of andrew jarrett

Hey @sindresorhus, I requested your review. There are still 2 open questions, would be good to get your take: 1) is `Patch` a good name for what this type does...

I could have done a better job communicating, let me give an example: The reason I don't think `UndefinedToType` is a good name is because if that's all someone needed,...

`ReplaceOptionalDeep` works for me. I agree that undefined is probably the less surprising default. @sindresorhus any objection to me extracting `ReplaceDeep` as its own type in a separate PR?

@sindresorhus this is ready for re-review. To address this question: > I don't want to design types for imaginary use-cases. Can you think of other types than `null` that `undefined`...

I apologize for not leaving a comment @sindresorhus, I was actually distracted by [this issue](https://github.com/microsoft/TypeScript/issues/55535), which the code in my PR was affected by. I closed this because I'm not...

@ajvincent that's great news -- I wasn't expecting such a quick turnaround. I reopened this PR and will extract `ReplaceDeep` this afternoon. @sindresorhus would you like me to somehow document...

I pushed up some changes. I still have to go back and rewrite things to A) remove old code, and B) rewrite things to be consistent with the rest of...

I've done the hard part of cleaning this up. Here's a playground so you can interact with it if that's helpful: [Playground](https://tsplay.dev/m3KDbm) I still need to figure out how to...

https://tsplay.dev/wQbdvN Tagging @ssalbdivad for visibility -- he's the one who thought to test this bug with `RequiredDeep`

Looks like this will be fixed by https://github.com/microsoft/TypeScript/pull/55638 🤞