Results 92 comments of Matthew Ahrens

Just a first guess: Do your `special` and regular vdevs have different sector sizes (`ashift`)? Maybe there's a bug in how we check if device removal is allowed. We should...

The fact that a vdev is `special` (or `dedup`) is called the "allocation bias", and this state is stored on-disk in the vdev_top_zap object associated with the vdev. This state...

The error message seems to be saying that what you're asking for is not implemented: `encrypted dataset ... may not be sent with properties without the raw flag` Note that...

I think we would need to create a more well-defined nvlist/json schema, instead of using the config nvlist.

I would prefer to eliminate the module parameter, and instead "use sector size **of this pool** as threshold". I.e. always make the threshold 1 sector (spa_max_ashift).

> Have my backup process pipe all confirmed-uploaded bytes to zstreamdump and use the resume token to resume the backup when interrupted. That won't necessarily work, because you don't know...

Before this change, you could set a quota on a filesystem, and it would ensure that you can't use (much) more space than the quota. From the zfsprops manpage: quota=size|none...

Thanks @behlendorf for pointing out that this commit doesn't actually "disable quota check for ZVOL", it merely adds a tunable to allow for disabling the quota check. The default behavior...

Thanks for the detailed overview in the description. One thing that I didn't quite catch: since the txg cadence of each pool (shared log pool, and each of the client...

That's neat. In Case 2 (`zfs destroy`), can we do the GC when the client pool is imported, instead of forcing the admin to do `zpool recycle`? It seems like...