REDPy icon indicating copy to clipboard operation
REDPy copied to clipboard

Duplicate server type checking when the type is file

Open indrarudia opened this issue 4 years ago • 1 comments

In the following lines:

https://github.com/ahotovec/REDPy/blob/098495a46acc753a303f22ecf859b646046ea71f/redpy/trigger.py#L43-L48

In the line 43, it checks if opt.server equal to file. Then, in the line 46 it also checks the same thing.

Type hinting may also report flist in the line 53 is possibly unbound.

https://github.com/ahotovec/REDPy/blob/098495a46acc753a303f22ecf859b646046ea71f/redpy/trigger.py#L50-L55

indrarudia avatar Oct 12 '20 05:10 indrarudia

Thanks for pointing this out. It's been a while since I've done housekeeping on these functions, and they've undergone a lot of changes the last few years.

ahotovec avatar Oct 16 '20 21:10 ahotovec