android-rss icon indicating copy to clipboard operation
android-rss copied to clipboard

Replace HttpClient with HttpURLConnection

Open Fleker opened this issue 8 years ago • 6 comments

Trying to compile with this library in my app on API level 25 and it's not working.

Error:(46, 13) Failed to resolve: org.apache.httpcomponents:httpclient:4.5

After examining some other help it seems like your library is using an old networking library that is not present in the latest versions of Android (and beyond).

Seems like the problem lies in the RSSReader class right at the start.

public RSSFeed load(String uri) throws RSSReaderException {
    HttpGet httpget = new HttpGet(uri);

With some slight tweaking of how the data is retrieved, it should be easy to replace this in the app without any other impact.

Fleker avatar Jun 02 '17 20:06 Fleker

Thanks Fleker.

With some slight tweaking of how the data is retrieved, it should be easy to replace this in the app without any other impact.

I'd be happy to merge a pull request for a patch that updates the version number of httpclient and tweaks the retrieval mechanism accordingly.

ahorn avatar Jun 02 '17 21:06 ahorn

Thank you Nick for the patch, merged. Have a good weekend.

ahorn avatar Jun 10 '17 01:06 ahorn

Thank you, could you update Gradle dependency pls?

ghost avatar Jun 11 '17 07:06 ghost

The dependency should automatically be updated using jitpack. Has it not?

Fleker avatar Jun 11 '17 18:06 Fleker

I still get that error during gradle build. (com.github.ahorn:android-rss:v1.0-rc1)

ghost avatar Jun 14 '17 20:06 ghost

Hi @Fleker, Hello @Onregs

For some time now, I wanted to update the README with some contributor information, and references to projects/products that are using android-rss. If you are willing to share any of this information, please feel free to provide the following, or a subset thereof:

  • Your name and/or organization you would like to be mentioned;
  • The project name, or product, that is using android-rss.

Many thanks again for your contributions!

ahorn avatar Oct 21 '17 16:10 ahorn