Alex Hoppen

Add a `sourcekit-lsp version` command that outputs the SourceKit-LSP version

4

Ideally, this would output the corresponding Swift version (eg. 6.0) and the commit hash from which it was built. Maybe we can use a build plugin to get the commit...

Currently, we don’t support syntactic test discovery from `BuildServerBuildSystem` because `BuildServerBuildSystem` does not implement `testFiles` and `addTestFilesDidChangeCallback`. We would probably need to design a BSP request/notification to implement these methods....

Figure out how to do background preparation for projects with a BSP build server

3

To index a target, we need to prepare it (which builds all the Swift modules of its dependencies) and for that we probably need a BSP request to prepare a...

Misaligned memory reads in lmdb

1

To reproduce run ``` UBSAN_OPTIONS=halt_on_error=true ~/swift-latest/usr/bin/swift test --sanitize=undefined --filter testBackgroundIndexingHappensWithLowPriority ``` Output ``` Test Case '-[SourceKitLSPTests.BackgroundIndexingTests testBackgroundIndexingHappensWithLowPriority]' started. /Users/alex/src/sourcekit-lsp/.command-line-build/checkouts/indexstore-db/lib/Database/lmdb/mdb.c:5916:14: runtime error: load of misaligned address 0x000109ddfffd for type 'unsigned short',...

Allocator.h:239:7: runtime error: null pointer returned from function declared to never return null

1

To reproduce run ``` UBSAN_OPTIONS=halt_on_error=true ~/swift-latest/usr/bin/swift test --sanitize=undefined --filter testObjectiveCTestsAfterInMemoryEdit ``` Output ``` Test Case '-[SourceKitLSPTests.DocumentTestDiscoveryTests testObjectiveCTestsAfterInMemoryEdit]' started. /Users/alex/src/sourcekit-lsp/.command-line-build/checkouts/indexstore-db/lib/LLVMSupport/include/llvm/Support/Allocator.h:239:7: runtime error: null pointer returned from function declared to never return...

Issue found by thread sanitizer: ```WARNING: ThreadSanitizer: thread leak (pid=31022) Thread T31 (tid=31250, finished) created by thread T7 at: #0 pthread_create ??:? (SourceKitLSPPackageTests.xctest+0x3da5c0) #1 std::thread::_M_start_thread(std::unique_ptr, void (*)()) ??:? (libstdc++.so.6+0xd3320) (BuildId:...

We can probably make indexing quite a bit more efficient by allowing multiple files from the same target to be indexed in a single swift-frontend invocation. That way the ASTContext...

Wait for index to be updated before workspace-wide operations like rename, call hierarchy and type hierarchy

1

It might make sense to wait for an up-to-date workspace wide index for global operations like rename, call hierarchy, or type hierarchy. The tricky part is how we communicate to...

Track dependencies more accurately in `SwiftPMBuildSystem.targets(dependingOn:)`

1

We currently use the topological sort to determine which targets depend on others. This is an over approximation because even targets that occur later in the topological sorting might be...

Figure out how to set the working directory for spawned processes on all platforms

1

Amazon Linux 2 and CentOS 7 have a glibc that doesn’t support `posix_spawn_file_actions_addchdir_np` and thus `TSCBasic.Process` can’t launch a process on these platforms with the working directory set. We currently...