sanic-session icon indicating copy to clipboard operation
sanic-session copied to clipboard

fix middleware registration for sanic 22.12.0+

Open Zerogoki00 opened this issue 2 years ago • 3 comments

https://github.com/ahopkins/sanic-session/issues/92

Zerogoki00 avatar Jan 10 '23 15:01 Zerogoki00

Thanks for contributing this. It helped me solve my problem.

Out of curiosity, why did you choose to do this rather than just uncommenting the @app.middleware("request") and @app.middleware("response") lines? I made that change on my end and it also seems to work. Any particular reason to use the explicit register_middleware API?

semmypurewal avatar Feb 22 '23 16:02 semmypurewal

Wow, I am super late at reviewing this. Sorry about that. We probably should update this to give it a high priority (if in the relevant Sanic version).

ahopkins avatar Sep 21 '23 15:09 ahopkins

Any update?

Zerogoki00 avatar Jan 21 '24 10:01 Zerogoki00