Adam Hopkins comments

Results 373 comments of


                                            Adam Hopkins

Fix request.url with full URI as SERVER_NAME

No worries. It really should only be the domain, but that doesn't mean because of historical reasons we shouldn't be supporting the scheme too. `//` is legit. For this PR...

Fix request.url with full URI as SERVER_NAME

If that is the the decision we need to do some validation. As it stands there is certainly a use when you would need an empty scheme and we are...

Fix request.url with full URI as SERVER_NAME

Yup. Consistency is the pain point here. I am hesitant to add yet another minor fix, and will try and take a crack in the coming weeks at revamping this....

Stopping an Async Webserver Closes the Event Loop, regardless if other things are running in the loop

@StuartFarmer Can you put together a PR so we can review it?

Stopping an Async Webserver Closes the Event Loop, regardless if other things are running in the loop

> @ahopkins If I have some more time, I can file a PR. It will make Sanic a lot more usable in more complex applications where you need more control...

Stopping an Async Webserver Closes the Event Loop, regardless if other things are running in the loop

> @ahopkins are you saying that this is fixed in 3.7? I meant to say that the example @mikepurvis shows above [has some 3.7+ only methods](https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.Server.serve_forever).

Stopping an Async Webserver Closes the Event Loop, regardless if other things are running in the loop

> All those methods are just sugar to make using asyncio more ergonomic, though. If Sanic needs to support 3.6, they could be easily reimplemented, or even just directly backported/monkey-patched,...

Stopping an Async Webserver Closes the Event Loop, regardless if other things are running in the loop

@StuartFarmer any luck?

Stopping an Async Webserver Closes the Event Loop, regardless if other things are running in the loop

@StuartFarmer Did you ever do any work on this?

Stopping an Async Webserver Closes the Event Loop, regardless if other things are running in the loop

The latest release added a `shutdown` for tasks that are named. I am thinking that maybe we could add to this functionality and simply add all tasks and that should...