Adam Hopkins

Results 354 comments of Adam Hopkins

This is planned to go out in the update with the 21.9 release. https://github.com/sanic-org/sanic-guide/pull/62

Can you [add some code formatting](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks) so it is easier to read?

Documentation, yes! But I want to leave it because it points to a larger issue in needing to update the API to make it more intuitive.

What about setting a default value to keep the existing OOTB functionality?

Makes absolute sense, and I would happily welcome a PR. The code base was largely copied from the earlier `sanic-openapi` package, which had very limited type hinting support. Because of...

Ooo! That's a nice touch. I'm on board with this. Let me know if you want to spec it out with me, or if you want to just throw together...

Correct, they made some breaking changes in their api. 👎 If you're interested in helping out, would be happy for you to make a PR. 😎

Sure thing. I want to get this in for release at the end of this month.

This still needs some more work to handle ```python @dataclass class Query: maybe: Optional[bool] = None ``` And particularly when dealing with `[None]`.

Why wontfix? It seems a legit request and a feature that is missing. Your docs themselves point out that setuptools is considered legacy.