Adam Hopkins

Results 354 comments of Adam Hopkins

I put some thought into this, and I think that the behavior is correct. Moving the graceful shutdown into `before_server_stop` (or, really, the equivalent in the server since it is...

This is a known thing. We will probably start with a warning and eventually raise an error for duplicate named routes. It will probably be a part of `sanic-routing` in...

I am going to solve this in app startup so we can provide a deprecation notice consistently.

The feature is mainly just a thin wrapper around `loop.create_task`. So, the answer is no. This does sound (however) like an interesting idea for a plugin.

> Or can it only be done through Python's own loop? E.g: > > ```python > async def generate_code(app): > while True: > await asyncio.sleep(5) > print('Server successfully started!') >...

> This is really a good idea It feels more like something we should add to `sanic-ext`.

Honestly, it is partially something I have been kicking around in my head for a long time as its own full blown project. But, there is probably a simpler implementation...

As a point of clarification, I agree. Speed is a primary concern that should generally trump others. However, Sanic _should not_ become an opinionated framework, and _should_ ultimately provide the...