Andrei Homescu comments

Results 57 comments of


                                            Andrei Homescu

Selfrando does not play well with delay loading on Windows

Fixed on Win64/Windows 10/MSVC 2015 by commit c0e7a0c10b3cf766b3a341a0faf7efc50a588a9d.

`long double` varargs won't compile

> bindgen uses u128 for long double From https://github.com/rust-lang/rust-bindgen/issues/1549 it sounds like they're not entirely happy with that either. > Why wouldn't f128 be implemented using u128? IMHO the real...

`size_t` is translated to `libc::c_ulong` instead of `libc::size_t`

> What puzzles me is why the transpiler is "evaluating" the typedef instead of using its name as-is. I haven't looked at this in a while, but it's probably coming...

Linux Kernel Module blog-post example broken due to `_Generic`

I don't remember anything about `_Generic`. Keep in mind this was 4 years ago, so it's very likely that the kernel code has also changed significantly. I didn't document the...

Linux Kernel Module blog-post example broken due to `_Generic`

> The relevant warning from your log appears to be: > > ``` > warning: c2rust: Encountered unsupported generic selection expression > ``` > > Which is caused by the...

Replace siphash and custom hashtable with Rust-native HashMap

We could go one step further: the only reason it even needs SipHash is for hash tables, so we could replace those with `HashMap`.

Re-transpile from Expat >=2.4.0 to gain protection against Billion Laughs Attacks (CVE-2013-0340)?

We have a large stack of changes on top of the previous transpilation, and re-transpiling would break all of them so it would probably be a huge amount of work....

Re-transpile from Expat >=2.4.0 to gain protection against Billion Laughs Attacks (CVE-2013-0340)?

I looked at the list of recent expat commits, and it looks like porting those over is also a giant task. I'm reconsidering your proposal of re-transpiling, it might work...

Import null pointer information from PDG into static analysis

I still need to test this on some actual code (maybe lighttpd?)

analyze: add NON_NULL rewrites

Left a couple of comments. This is a large PR, it will take me a while to get through.