kubectx icon indicating copy to clipboard operation
kubectx copied to clipboard

Adding skim support

Open frzam opened this issue 3 years ago • 5 comments

See the Feature request here

Added skim support in kubens and kubectx go version.

Added environment variable PICKER which will contain value sk or fzf, if PICKER is not set or anything else is set other than sk and fzf, then it will by default pick fzf.

Created a func InteractiveSearch in interactive.go which will be called for fuzzy search and renamed fzf.go to fuzzy.go since it is now more generic.

frzam avatar Aug 08 '21 14:08 frzam

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 08 '21 14:08 googlebot

@googlebot I signed it!

frzam avatar Aug 08 '21 14:08 frzam

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 08 '21 14:08 googlebot

Hey, sorry I've been slow reviewing things! For compatibility purposes, do you mind if we check fzf first, then sk? I am suspecting if people have another binary somehow called sk in their PATH, their workflow might be broken. (And this can work because I assume sk users don't have fzf installed?)

ahmetb avatar Aug 30 '21 17:08 ahmetb

For those who are waiting for this PR to be merged, you can create an alias with kubectx $(kubectx | sk), it's not a pefect solution but it works.

EDIT: typo

sambonbonne avatar Apr 11 '22 09:04 sambonbonne