kubectx
kubectx copied to clipboard
Add message when no contexts are found in kubeconfig
What did I do?
- Added message for empty contexts in both fzf.go and lists.go
- Updated Implementation test 17
- Tested Locally
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.
. If the bot doesn't comment, it means it doesn't think anything has changed.
ℹ️ Googlers: Go here for more info.
You need to implement integration tests as well I believe.
@googlebot I fixed it
@googlebot I fixed it
You need to implement integration tests as well I believe.
test case 17, delete several contexts validates this, I've updated the test case. Should I still write a separate test for this?
you're right it's technically capturing this case, but it's more ideal if we copy-paste it into its own test case. technically we want to have 1:1 mapping between "behavior we want to test" and "integration test case".