Ahmet Alp Balkan

Results 799 comments of Ahmet Alp Balkan

I'm sorry neither the plugin name is descriptive enough to reflect the plugin's functionality, nor the description clearly explains what the plugin does, and the repo has little to detail...

Currently there are multiple plugins tools that allow switching between clusters and namespaces. I'm currently failing to see how's AKS related to these tasks and why the plugin is specific...

:robot: _Beep beep! I’m a robot speaking on behalf of @ahmetb._ :robot: ----- Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon....

FYI I noticed you're doing https://github.com/teocns/kubectl-finalize/blob/019a6e5b2809c28cd65fcd2a4997d828a2d02c47/pkg/rm/force_delete.go#L150-L160 Did you know you can use cli-runtime and avoid all that stuff? https://speakerdeck.com/alp/building-kubectl-plugins-like-a-pro I have a recording of this deck available as well. I...

@teocns any updates here?

/lgtm /approve Sorry for the delay. I must've missed the notifications. Also, please consider setting up [Krew release automation](https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/) which helps you skip manually making updates to your Krew manifests...

:robot: _Beep beep! I’m a robot speaking on behalf of @ahmetb._ :robot: ----- Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon....

There are quite a few plugins that support running across multiple namespaces/context at a time in `krew-index`. We likely wouldn't accept a plugin for just running a specific command across...

Sorry this plugin still does not make a ton of sense to me. krew-index is a curated index and if a plugin's value add is easily achievable by composing existing...

:robot: _Beep beep! I’m a robot speaking on behalf of @ahmetb._ :robot: ----- This pull request **does not** seem to be a straightforward version bump. I'll have a human review...