Ahmet Alp Balkan

Results 656 comments of Ahmet Alp Balkan

I think a UI like the Rectangle's screenshot in its readme where people can go to modify the hotkeys is the most preferable as it's for both learning and modifying.

Shields are usually for status; not call to action. I personally don't click on them often. Would this be an alternative "button"?

I am thinking we should probably scale down the original svg so that people don’t resort to html.

I tried height=40 (by saving this to github gists + save as .md), and it seems to render better. height=20 is a bit too small. Currently it's 50px, so shrink...

Not a bad idea tbh. We opted in to ?git_repo since we have other options coming in as querystrings. We can support both formats.

Though, trivially replacing the hostname (e.g. tree/{REF}/{SUBDIR} etc) can take bit more work, but the code is already there since we already do Referer detection.

Though, this domain name replacement assumes GitHub, but we actually GitLab today as well. That creates a preferential treatment towards GitHub. Maybe it’s OK in this case. It's a cool...

Agreed. Based on my experience, the `pack` stuff isn't in a mature shape yet either (#3), so we can put alternative "builders" on hold for now.

If you can mention the error, we can help it not clash (by perhaps introducing a placeholder for fields that aren't supported).

We can try and fix `buildpacks` argument, but I assume this is not a good idea. Because that value is critical to how the app is built. And we better...