Taahir Ahmed

Results 28 comments of Taahir Ahmed

@enj Did you get any feedback from folks at Microsoft? There's been no other feedback on the mailing list. I'm inclined to settle on the sha256 fingerprint.

> signature B. For any arbitrarily constructed TBSCert C, it is trivial to find a public key that would sign C producing the same signature B. Signatures where the key...

It looks like the 1.31 freeze is over --- should we merge this now?

> /lgtm /hold cancel > > please open a docs update against the dev-1.32 website branch to add details about this to the certificate authentication section https://github.com/kubernetes/website/pull/47715

This PR is adapted from https://github.com/GoogleCloudPlatform/magic-modules/pull/11733 since @tonyzhc is on vacation.

OK , I updated both using `go get -v -u google.golang.org/[email protected]`

> Waiting on test fix Uploaded, let's see if it passes now.

> ``` > sh -c "'/home/runner/work/magic-modules/magic-modules/scripts/gofmtcheck.sh'" > ==> Checking that code complies with gofmt requirements... > Error: ./google/services/container/resource_container_cluster.go:6056:2: expected operand, found 'if' > go vet > # github.com/hashicorp/terraform-provider-google/google/services/container > Error:...