LLG-MP icon indicating copy to clipboard operation
LLG-MP copied to clipboard

Published 20 hours ago • verified publisher icon ahmedmaher05

Mac OS support

Open colossatr0n opened this issue 3 years ago • 5 comments

Just putting in an enhancement request to add Mac OS support.

Since this is an electron-app, what exactly does this conversion entail? Does the actual logic of LLG-MP need to be changed, or is it mostly build and dependency stuff?

colossatr0n avatar Sep 20 '21 23:09 colossatr0n

I actually started working on a feature branch and have it running now. I'll see if I can flesh out the rest of the branch and then I'll submit a PR for Mac OS support.

colossatr0n avatar Sep 21 '21 08:09 colossatr0n

No major stuff, Mostly dependencies indeed.

great job @colossatr0n , the merge works successfully but has some minor conflicts with regression testing for some other features. kindly provide your email/skype or join the Gitter chat link in the README.md section if you are free to give me a hand in solving the regression test issues together. nevertheless, I will work on it ASAP if you were busy.

ahmedmaher05 avatar Sep 23 '21 14:09 ahmedmaher05

Thank you! I just joined the Gitter chatroom.

colossatr0n avatar Sep 23 '21 15:09 colossatr0n

Great, gonna catch up with you there in a while

ahmedmaher05 avatar Sep 23 '21 15:09 ahmedmaher05

Fixed some more issues with the PR. Hopefully that'll resolve some of those regressions.

colossatr0n avatar Sep 27 '21 22:09 colossatr0n