accelerated-mobile-pages icon indicating copy to clipboard operation
accelerated-mobile-pages copied to clipboard

Published 20 hours ago • verified publisher icon ahmedkaludi

Use select2 for user experience

Open ahmedkaludi opened this issue 4 years ago • 5 comments

0339C787-C5DE-40E0-A7D8-39AE639DA813

ahmedkaludi avatar Jul 30 '20 19:07 ahmedkaludi

one more user-requested for this: https://secure.helpscout.net/conversation/1301867187/158082?folderId=2770545

akashagrjsr avatar Oct 06 '20 13:10 akashagrjsr

Ready to merge. @Zabi09 Do a test before and after the merging for this ticket, to make sure that the ticket is properly fixed and we don't have any JS errors in Console.

MohammedKaludi avatar Oct 07 '20 06:10 MohammedKaludi

Need to add max-width to align the size of the Select as the select is overlapping the spinner and is bigger than rest of selects. https://monosnap.com/file/6GlB6fbOQdl7dBQ2JPgHPzllEPoVhc

MohammedKaludi avatar Oct 14 '20 06:10 MohammedKaludi

mins.css me bhi dalna hai

Also this seems incorrrect place to add the code. https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/5386088b1f474acce1e8adcef5880bc052361542#diff-513f6a7b1c12966c6f2cf71d995c5b283af2ecbe6505b6b4d3f75805f75c907dR484

MohammedKaludi avatar Oct 14 '20 07:10 MohammedKaludi

Pushed in 1.0.65 update, But need to test once again for final time to make sure everything is working and sometimes scroll event is turning off, is it due to this? Do let me know on how to test the scroll issue. If working fine then the ticket can be cloased.

MohammedKaludi avatar Oct 15 '20 12:10 MohammedKaludi