accelerated-mobile-pages icon indicating copy to clipboard operation
accelerated-mobile-pages copied to clipboard

Published 20 hours ago • verified publisher icon ahmedkaludi

Detect WP_DEBUG and give option of ON and OFF

Open akashagrjsr opened this issue 5 years ago • 7 comments

Help Scout Link: https://secure.helpscout.net/conversation/845466698/64849?folderId=2770545

akashagrjsr avatar May 06 '19 11:05 akashagrjsr

Please use ampforwp_get_setting and change the position of it - https://prnt.sc/oyin3g and also it should be off by default

Zabi09 avatar Aug 28 '19 07:08 Zabi09

Removed debug mode from advanced setting and added as admin notice. It will be visible when wp_debug is true in wp_config.php file

WasimM3 avatar Aug 29 '19 05:08 WasimM3

Need to remove the space from WP_DEBUG - https://take.ms/6ZfgX because if there is a space then it is not working.

sonaliramteke avatar Aug 29 '19 12:08 sonaliramteke

  1. Add nonce verification in all wp_ajax
  2. check user capability to save option before replacing debug mode
  3. Show admin notice only for Administrator

ajeetku avatar Aug 31 '19 08:08 ajeetku

escaping missing in nonce https://github.com/ahmedkaludi/accelerated-mobile-pages/commit/0376fffb128b08c2b35cce0b5ac7c03acacbbbe2#diff-4c7e8aaf3d2ea6555ce6cdd4ecae8e69R1207

MohammedKaludi avatar Sep 17 '19 15:09 MohammedKaludi

Ready to mereg.

MohammedKaludi avatar Sep 23 '19 12:09 MohammedKaludi

https://monosnap.com/file/AOkWQxvO6pnp4Y7D11dCuSV46aAaj1

  • [ ] multiple issues, Discuss with @ahmedkaludi directly

raju-jeelaga avatar Nov 05 '19 14:11 raju-jeelaga